Skip to content

Commit 84a1553

Browse files
authored
Close CacheDecayTask when FrozenCacheService is closed (#71693)
CacheDecayTask is scheduled when the FrozenCacheService is instantiated but it should also be closed accordingly when the service is closed.
1 parent ce389df commit 84a1553

File tree

1 file changed

+1
-2
lines changed
  • x-pack/plugin/searchable-snapshots/src/main/java/org/elasticsearch/xpack/searchablesnapshots/cache/shared

1 file changed

+1
-2
lines changed

x-pack/plugin/searchable-snapshots/src/main/java/org/elasticsearch/xpack/searchablesnapshots/cache/shared/FrozenCacheService.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
import org.elasticsearch.cluster.node.DiscoveryNodeRole;
1717
import org.elasticsearch.common.lease.Releasable;
1818
import org.elasticsearch.common.lease.Releasables;
19-
import org.elasticsearch.common.logging.DeprecationLogger;
2019
import org.elasticsearch.common.settings.Setting;
2120
import org.elasticsearch.common.settings.Settings;
2221
import org.elasticsearch.common.settings.SettingsException;
@@ -162,7 +161,6 @@ public Iterator<Setting<?>> settings() {
162161
);
163162

164163
private static final Logger logger = LogManager.getLogger(FrozenCacheService.class);
165-
private static final DeprecationLogger deprecationLogger = DeprecationLogger.getLogger(FrozenCacheService.class);
166164

167165
private final ConcurrentHashMap<RegionKey, Entry<CacheFileRegion>> keyMapping;
168166

@@ -499,6 +497,7 @@ int getFreq(CacheFileRegion cacheFileRegion) {
499497
@Override
500498
public void close() {
501499
sharedBytes.decRef();
500+
decayTask.close();
502501
}
503502

504503
class CacheDecayTask extends AbstractAsyncTask {

0 commit comments

Comments
 (0)