bypass assert-no-failure in the newly added test

Author: dnhatn

server/src/main/java/org/elasticsearch/indices/recovery/RecoveryTarget.java

@@ -33,6 +33,7 @@
 import org.elasticsearch.common.bytes.BytesReference;
 import org.elasticsearch.common.logging.Loggers;
 import org.elasticsearch.common.lucene.Lucene;
+import org.elasticsearch.common.settings.Settings;
 import org.elasticsearch.common.util.CancellableThreads;
 import org.elasticsearch.common.util.concurrent.AbstractRefCounted;
 import org.elasticsearch.index.engine.Engine;
@@ -353,7 +354,10 @@ public void indexTranslogOperations(
                 }
                 if (result.getFailure() != null) {
                     if (Assertions.ENABLED) {
-                        throw new AssertionError("unexpected failure while replicating translog entry", result.getFailure());
+                        final Settings settings = indexShard.indexSettings().getSettings();
+                        if (settings.getAsList("assertion.disabled").contains(getClass().getName()) == false) {
+                            throw new AssertionError("unexpected failure while replicating translog entry", result.getFailure());
+                        }
                     }
                     ExceptionsHelper.reThrowIfNotNull(result.getFailure());
                 }

server/src/test/java/org/elasticsearch/indices/recovery/IndexRecoveryIT.java

@@ -42,6 +42,7 @@
 import org.elasticsearch.cluster.routing.RecoverySource.SnapshotRecoverySource;
 import org.elasticsearch.cluster.routing.allocation.command.MoveAllocationCommand;
 import org.elasticsearch.cluster.service.ClusterService;
+import org.elasticsearch.common.settings.Setting;
 import org.elasticsearch.common.settings.Settings;
 import org.elasticsearch.common.unit.ByteSizeUnit;
 import org.elasticsearch.common.unit.ByteSizeValue;
@@ -82,6 +83,7 @@
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.Collection;
+import java.util.Collections;
 import java.util.List;
 import java.util.Map;
 import java.util.concurrent.CountDownLatch;
@@ -90,6 +92,7 @@
 import java.util.concurrent.atomic.AtomicBoolean;
 import java.util.concurrent.atomic.AtomicInteger;
 import java.util.function.Consumer;
+import java.util.function.Function;
 
 import static java.util.Collections.singletonMap;
 import static org.elasticsearch.node.RecoverySettingsChunkSizePlugin.CHUNK_SIZE_SETTING;
@@ -119,7 +122,7 @@ public class IndexRecoveryIT extends ESIntegTestCase {
     @Override
     protected Collection<Class<? extends Plugin>> nodePlugins() {
         return Arrays.asList(MockTransportService.TestPlugin.class, MockFSIndexStore.TestPlugin.class,
-                RecoverySettingsChunkSizePlugin.class, TestAnalysisPlugin.class);
+                RecoverySettingsChunkSizePlugin.class, TestAnalysisPlugin.class, AssertionPlugin.class);
     }
 
     @After
@@ -875,7 +878,7 @@ public void testHistoryRetention() throws Exception {
     }
 
     public void testDoNotInfinitelyWaitForMapping() {
-        internalCluster().ensureAtLeastNumDataNodes(3);
+        internalCluster().startNodes(3, Settings.builder().put("assertion.disabled", RecoveryTarget.class.getName()).build());
         createIndex("test", Settings.builder()
             .put("index.analysis.analyzer.test_analyzer.type", "custom")
             .put("index.analysis.analyzer.test_analyzer.tokenizer", "standard")
@@ -926,4 +929,13 @@ public TokenStream create(TokenStream tokenStream) {
                 });
         }
     }
+
+    public static final class AssertionPlugin extends Plugin {
+        @Override
+        public List<Setting<?>> getSettings() {
+            return Collections.singletonList(
+                Setting.listSetting("assertion.disabled", Collections.emptyList(), Function.identity(), Setting.Property.NodeScope)
+            );
+        }
+    }
 }