Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the mechanism to enable LogsDB #113507

Closed
salvatore-campagna opened this issue Sep 25, 2024 · 1 comment · Fixed by #113505
Closed

Change the mechanism to enable LogsDB #113507

salvatore-campagna opened this issue Sep 25, 2024 · 1 comment · Fixed by #113505

Comments

@salvatore-campagna
Copy link
Contributor

salvatore-campagna commented Sep 25, 2024

Description

With PR #109025 we introduced a mechanism relying on component templates
to enable LogsDB. This mechanism uses a static setting and despite being useful to enable LogsDB for new deployments
it makes it difficult to do so for existing deployments. Moreover, changing component templates
like logs@settings requires bumping the stack template registry version. As a result, enabling LogsDB requires pushing
a change and redeploying. This makes LogsDB activation quite involved.

We decided to introduce a new mechanism that makes enabling LogsDB easier and that does not rely on templates
and/or component templates. We can use the existing IndexSettingProvider functionality to evaluate a cluster setting
cluster.logsdb.enabled at index creation time and, under certain conditions, inject the index.mode setting with value
logsdb.

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

@salvatore-campagna salvatore-campagna self-assigned this Sep 25, 2024
@salvatore-campagna salvatore-campagna changed the title Introduce a new mechanism to enable LogsDB Change the mechanism to enable LogsDB Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants