Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove retry logic from IndicesClusterStateService #15896

Closed
jasontedor opened this issue Jan 11, 2016 · 5 comments
Closed

Remove retry logic from IndicesClusterStateService #15896

jasontedor opened this issue Jan 11, 2016 · 5 comments
Labels
:Distributed Indexing/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. >enhancement Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. >tech debt

Comments

@jasontedor
Copy link
Member

IndicesClusterStateService currently manages its own retries when managing shard state. Channel related failures will now be managed in ShardStateAction (#15748, #15895) so the retry logic should be refactored there to only handle non-channel failures.
@jasontedor jasontedor self-assigned this Jan 11, 2016
@jasontedor jasontedor mentioned this issue Jan 11, 2016
Merged
@jasontedor jasontedor changed the title Remove retry logic from IndicesClusterService Remove retry logic from IndicesClusterStateService Mar 25, 2016
@jasontedor jasontedor assigned ywelsch and unassigned jasontedor May 19, 2016
@clintongormley clintongormley added :Distributed Indexing/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. and removed :Cluster labels Feb 13, 2018
@bleskes
Copy link
Contributor

bleskes commented Mar 20, 2018

This issue is w.r.t to resending of shard failed message on each incoming cluster state. This can cause an barrage of shard failed messages. It is unneeded as ShardStateAction is now more resilient and should take care of all the retries (network failures, master loss , etc)

@jgq2008303393
Copy link

@bleskes we still encounter this problem in 5.6.4.

https://discuss.elastic.co/t/half-dead-node-lead-to-cluster-hang/113658

@bleskes
Copy link
Contributor

bleskes commented Apr 9, 2018

@jgq2008303393 the issue is still open, so sadly, that's expected.

@dnhatn dnhatn mentioned this issue Jun 14, 2018
Merged
@dnhatn dnhatn removed the v5.4.4 label Aug 23, 2019
@rjernst rjernst added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label May 4, 2020
@dnhatn dnhatn removed their assignment Feb 10, 2021
@ywelsch ywelsch removed their assignment Apr 1, 2021
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@DaveCTurner
Copy link
Contributor

This class has been drastically simplified since 2016 and I think there's no retry logic in IndicesClusterStateService any more so I'm closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Distributed Indexing/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. >enhancement Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. >tech debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
10 participants
@clintongormley @rjernst @jgq2008303393 @bleskes @pxsalehi @ywelsch @jasontedor @DaveCTurner @dnhatn @elasticsearchmachine