Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase chunk_size max to 256 Mb instead of 64 Mb #23446

Closed
dadoonet opened this issue Mar 2, 2017 · 9 comments
Closed

Increase chunk_size max to 256 Mb instead of 64 Mb #23446

dadoonet opened this issue Mar 2, 2017 · 9 comments
Labels
:Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >enhancement good first issue low hanging fruit help wanted adoptme

Comments

@dadoonet
Copy link
Member

dadoonet commented Mar 2, 2017

While working on an azure issue, I found this documentation which says that we can now increase the max block blob to 256mb instead of the default 64mb which has been introduced in #22577

About Block Blobs

Block blobs let you upload large blobs efficiently. Block blobs are comprised of blocks, each of which is identified by a block ID. You create or modify a block blob by writing a set of blocks and committing them by their block IDs. Each block can be a different size, up to a maximum of 100 MB (4 MB for requests using REST versions before 2016-05-31), and a block blob can include up to 50,000 blocks. The maximum size of a block blob is therefore slightly more than 4.75 TB (100 MB X 50,000 blocks). For REST versions before 2016-05-31, the maximum size of a block blob is a little more than 195 GB (4 MB X 50,000 blocks). If you are writing a block blob that is no more than 256 MB (64 MB for requests using REST versions before 2016-05-31) in size, you can upload it in its entirety with a single write operation; see Put Blob.

@dadoonet
Copy link
Member Author

dadoonet commented Mar 2, 2017

See also #23448

@nmjacob
Copy link

nmjacob commented Mar 2, 2017

I am new to GitHub public projects, so if possible I would like to make this my first fix on the project. That way I can dip my toe in the water.

@peterleonardlie
Copy link

Hi, I've changed the maximum chink size from 64MB to 256MB

@dadoonet
Copy link
Member Author

dadoonet commented Mar 4, 2017

Thanks @peterleonardlie for your PR but @nmjacob said first that he would like to contribute to the project.

So if you don't mind, I'd like that he starts the effort with our help.
Do you mind closing your PR and take another one like #23448 to contribute?

Thanks!

@peterleonardlie
Copy link

sure no problem! im sorry for starting it then, because i see nothing happened after a day :)

@nmjacob
Copy link

nmjacob commented Mar 6, 2017

Forgive me for my ignorance, but I just submitted a pr to fix this. Do I need to link it to the issue in any way? Sorry about the delay getting the fix done.

@dadoonet
Copy link
Member Author

@nmjacob You just have to create the PR and add Closes #23446. in your commit message so the PR will contain also this text and will be linked to this issue.

@batradhruv
Copy link

batradhruv commented Jul 30, 2018

Can I pick this up? New to open source code. This would be my first pr

@ywelsch
Copy link
Contributor

ywelsch commented Jul 31, 2018

@batradhruv this was already picked up, see #32101 and #12448

@ywelsch ywelsch closed this as completed Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >enhancement good first issue low hanging fruit help wanted adoptme
Projects
None yet
Development

No branches or pull requests

7 participants