-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When faceting on integer field using TERMS , 0.9 fails to count records where the facet field is missing #2807
Comments
thanks for reporting this. we will look into it soon |
thanks, note that not only missing field is not right but total field (within facets) is also less than it should be (100 vs 200 hits) You probably do not need all 200 docs just 5 will do the job. I was just struggling to reproduce it since it appeared very erratic from my app (some facets working and some not) till I realized it is the ones on numeric fields which are broken |
Hi Clint, So size=0 is a regression relative to 0.20.5 because 0.20.5 does support it? Any chance it'll be supported in 0.9GA? Also may I ask if there is any hope to have terms_stats support total/count (if not the rest of stats) for "missing" and "other" like terms does? It would be very helpful. Right now I decompose my terms_stats to 3 facets, terms_stats, stats with missing filter and stats for that field to calculate "complete" totals (per term, other, missing) and then recompose results back. I also have few useful and simple ideas for new facets ("logical" facets I currently use by decomposing them onto multiple ES facets and recomposing data together) just not sure it is a good time to lobby for them :-) |
@roytmana can you open a sep. issue for the |
There is a similar issue #1776 Would you like me to open another one specifically for 0.9RC1? |
@roytmana well I wonder why this one is still open if that is in 0.20.5 so lets sort that out first, can you comment? |
I was not aware of that old issue. Clint pointed it out (see above) I as happily using it since 0.20.3 or 4 |
Hiya @roytmana. I've checked on 0.20.3-0.20.5 and specifying cilnt |
sorry you are correct I mixed it up. I was having problem with it in 0.20.3 and then moved to terms_stats facet (since I needed some $ totals anyways) which supports it correctly and now mixed it up. It is not working in 0.20.5 It would be very nice to make terms and terms_stats consistent in two ways
|
reproduceable example:
https://gist.github.com/roytmana/5215441
sorry my curl commands could be somewhat wrong - I am on windows and not using it much
The text was updated successfully, but these errors were encountered: