Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix task ordering for checkstyle Java 9 #28376

Closed
jasontedor opened this issue Jan 25, 2018 · 0 comments · Fixed by #28383
Closed

Fix task ordering for checkstyle Java 9 #28376

jasontedor opened this issue Jan 25, 2018 · 0 comments · Fixed by #28383
Assignees
Labels
:Delivery/Build Build or test infrastructure jdk9 Team:Delivery Meta label for Delivery team

Comments

@jasontedor
Copy link
Member

The checkstyle configuration here is broken:

  • we are not configuring checkstyle for Java 9
  • the source set for Java 9 is not configured until after we have configured the checkstyle task

This can lead to bad ordering:

:server:checkstyleJava9 SKIPPED
:server:copyCheckstyleConf SKIPPED
:server:checkstyleMain SKIPPED

so the :server:checkstyleJava9 can fail with

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':server:checkstyleJava9'.
> Unable to create Root Module: configLocation {/home/jason/src/elastic/elasticsearch/server/build/checkstyle/checkstyle.xml}, classpath {/home/jason/src/elastic/elasticsearch/server/build/classes/java/java9:/home/jason/src/elastic/elasticsearch/server/build/resources/java9:/home/jason/src/elastic/elasticsearch/server/build/classes/java/main:/home/jason/src/elastic/elasticsearch/server/build/resources/main}.
@jasontedor jasontedor added >bug :Delivery/Build Build or test infrastructure jdk9 labels Jan 25, 2018
@jasontedor jasontedor self-assigned this Jan 25, 2018
@colings86 colings86 removed the >bug label Jan 31, 2018
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Delivery/Build Build or test infrastructure jdk9 Team:Delivery Meta label for Delivery team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants