Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for custom per request maxRetryTimeout on RestClient #32724

Closed
filiphr opened this issue Aug 8, 2018 · 5 comments
Closed

Support for custom per request maxRetryTimeout on RestClient #32724

filiphr opened this issue Aug 8, 2018 · 5 comments
Labels
:Clients/Java Low Level REST Client Minimal dependencies Java Client for Elasticsearch >enhancement

Comments

@filiphr
Copy link

filiphr commented Aug 8, 2018

Currently it is not possible to configure the maxRetryTimeout in the RestClient on a case by case bases for the sync requests. It would be good to have such support.
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@javanna
Copy link
Member

javanna commented Aug 10, 2018

Agreed, related to #21789 if not the same issue. Also #25951 is related.

@filiphr
Copy link
Author

filiphr commented Aug 10, 2018

Just saw that this has been marked for the High Level REST Client. It would be good to have it there as well, but I was referring more to the Low Level REST Client. I think it would make sense to have it there as well.

@javanna javanna added :Clients/Java Low Level REST Client Minimal dependencies Java Client for Elasticsearch and removed :Core/Java High Level REST Client labels Aug 10, 2018
@javanna
Copy link
Member

javanna commented Aug 10, 2018

you are correct @filiphr , this is a low-level REST client change that the high-level REST would also benefit from, automatically. Thanks for noticing that.

@javanna
Copy link
Member

javanna commented Feb 6, 2019

This no longer applies, we have deprecated max retry timeout in 6.x, as well as increased its default value to 90 seconds (#38425) and removed it in 7.0 (#38085).

@javanna javanna closed this as completed Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Clients/Java Low Level REST Client Minimal dependencies Java Client for Elasticsearch >enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@colings86 @javanna @filiphr @elasticmachine