Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to weight matches in the Unified highlighter #33578

Closed
jimczi opened this issue Sep 10, 2018 · 2 comments
Closed

Switch to weight matches in the Unified highlighter #33578

jimczi opened this issue Sep 10, 2018 · 2 comments
Labels
>enhancement :Search Relevance/Highlighting How a query matched a document Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch team-discuss

Comments

@jimczi
Copy link
Contributor

jimczi commented Sep 10, 2018

The unified highlighter has a new mode that uses the matches API to perform highlighting:
https://issues.apache.org/jira/browse/LUCENE-8286
The main benefit of this mode is that it highlights boolean query accurately. Should we activate this mode by default ? This would be breaking since highlighting would be different so we could also add an option in 6x to activate this mode.

@jimczi jimczi added >enhancement :Search Relevance/Highlighting How a query matched a document labels Sep 10, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

@jimczi
Copy link
Contributor Author

jimczi commented Sep 24, 2018

We discussed internally and we've decided to create a new highlighter that will leverage the Matches API to perform highlighting. We don't want to add a new flag to the unified highlighter that would completely change the logic of the output so a new highlighter seems a better option. Some options will not be available due to how the logic is implemented, so for instance require_field_match would always be true since the Matches API ensures that the highlighted part are real "matches" in the document. I am closing this issue but opened #34015 to track the addition of this new highlighter.

@jimczi jimczi closed this as completed Sep 24, 2018
@javanna javanna added the Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch label Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>enhancement :Search Relevance/Highlighting How a query matched a document Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch team-discuss
Projects
None yet
Development

No branches or pull requests

3 participants