Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 'template field' from parsing logic in IndexTemplateMetaData #38502

Closed
martijnvg opened this issue Feb 6, 2019 · 4 comments
Closed

Remove 'template field' from parsing logic in IndexTemplateMetaData #38502

martijnvg opened this issue Feb 6, 2019 · 4 comments
Labels
:Data Management/Indices APIs APIs to create and manage indices and templates

Comments

@martijnvg
Copy link
Member

Parsing the template field has been deprecated a long time in IndexTemplateMetaData.Builder.fromXContent(...) method and should be removed.

Originates from: #38448 (comment)
@martijnvg martijnvg added the :Data Management/Indices APIs APIs to create and manage indices and templates label Feb 6, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features

@jakelandis
Copy link
Contributor

This should only be merged to 7.x since we have some internal clients on 6.x that still use the template field

@PnPie PnPie mentioned this issue May 11, 2019
Merged
@PnPie
Copy link
Contributor

PnPie commented May 11, 2019

Hello,
I created a PR for this ;)

@Mpdreamz Mpdreamz mentioned this issue Aug 7, 2019
Closed
16 tasks
@dakrone
Copy link
Member

dakrone commented Sep 6, 2019

Closing this since the PR that removed it has been merged.

@dakrone dakrone closed this as completed Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Data Management/Indices APIs APIs to create and manage indices and templates
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@dakrone @martijnvg @jakelandis @PnPie @elasticmachine