Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "origin" string (or metadata) to CreateSnapshotRequest #40638

Closed
dakrone opened this issue Mar 29, 2019 · 3 comments
Closed

Add "origin" string (or metadata) to CreateSnapshotRequest #40638

dakrone opened this issue Mar 29, 2019 · 3 comments
Assignees
Labels
:Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >enhancement

Comments

@dakrone
Copy link
Member

dakrone commented Mar 29, 2019

In #38461 we are working towards a snapshot lifecycle management where snapshots can automatically be taken. One thing that would be helpful, however, is to know how a snapshot originated (like which policy created the snapshot).

It would be great if we could extend the CreateSnapshotRequest (and optionally the REST layer) to allow providing an "origin" (or metadata, if we want to be more generic) string when creating the snapshot. This would then show up when the snapshot was listed from the repository.

/cc @original-brownbear

@dakrone dakrone added >enhancement :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs labels Mar 29, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

@ywelsch
Copy link
Contributor

ywelsch commented Mar 29, 2019

I would prefer to have a general-purpose _meta field (like we have for mappings) rather than an "origin" field.

@gwbrown
Copy link
Contributor

gwbrown commented Jun 6, 2019

This has been implemented in #41281.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >enhancement
Projects
None yet
Development

No branches or pull requests

4 participants