Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[telemetry] _xpack/usage endpoint missing dataframe #46819

Closed
Bamieh opened this issue Sep 18, 2019 · 4 comments
Closed

[telemetry] _xpack/usage endpoint missing dataframe #46819

Bamieh opened this issue Sep 18, 2019 · 4 comments
Labels
>bug :Core/Infra/Core Core issues without another label :ml Machine learning

Comments

@Bamieh
Copy link
Member

Bamieh commented Sep 18, 2019

Hello 👋

We have a test in kibana that checks that we are sending all the telemetry fields. Currently it is failing on master because xpack.data_frame is missing from the payload.

All the stack_stats.xpack.* telemetry data is passed directly from elasticsearch _xpack/usage endpoint.

Ideally it would be great to have the same tests we have on kibana checking for those fields in elasticsearch as well, this way we'll have increased confidence that those fields will return what we expect when swapping between snapshots.

We do check for the following fields returned from elasticsearch:

expect(stats.stack_stats.xpack.graph).to.be.an('object');
expect(stats.stack_stats.xpack.data_frame).to.be.an('object');
expect(stats.stack_stats.xpack.data_frame.available).to.be.an('boolean');
expect(stats.stack_stats.xpack.data_frame.enabled).to.be.an('boolean');
expect(stats.stack_stats.xpack.ilm).to.be.an('object');
expect(stats.stack_stats..xpack.logstash).to.be.an('object');
expect(stats.stack_stats.xpack.ml).to.be.an('object');
expect(stats.stack_stats.xpack.monitoring).to.be.an('object');
expect(stats.stack_stats.xpack.rollup).to.be.an('object');

currently we get the following keys in the payload (data_frame is missing)

curl -XGET localhost:9200/_xpack/usage -u elastic:changeme -k | jq 'keys'                                                 
[
  "analytics",
  "ccr",
  "flattened",
  "frozen_indices",
  "graph",
  "ilm",
  "logstash",
  "ml",
  "monitoring",
  "rollup",
  "security",
  "spatial",
  "sql",
  "transform",
  "vectors",
  "voting_only",
  "watcher"
]

Related: elastic/kibana#45983
Related: elastic/kibana#45884

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core

@alpar-t
Copy link
Contributor

alpar-t commented Sep 23, 2019

👍 on adding similar tests to ES

@hendrikmuhs
Copy link

This is by design as the data frame plugin gets renamed to transform for 7.5. The kibana side needs updates.

Moving to kibana: elastic/kibana#46325

+1 on adding similar tests to ES

There are tests which tests the usage endpoint, which have been updated as part of the PR. I missed to update kibana tests as I wasn't aware of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Core/Infra/Core Core issues without another label :ml Machine learning
Projects
None yet
Development

No branches or pull requests

5 participants