Failure of :modules:transport-netty4:test on master

[przemekwitek]

Build | 20191022054831-A81DC5D0
Log | https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+master+multijob-windows-compatibility/os=windows-2012-r2/215/console
Build Scans | https://gradle-enterprise.elastic.co/s/hpnzc7hnzftce

Reproduce line:

REPRODUCE WITH: gradlew ':modules:transport-netty4:test' --tests "org.elasticsearch.transport.netty4.SimpleNetty4TransportTests.testLocalNodeConnection" \
  -Dtests.seed=175DFFF16E9928FC \
  -Dtests.security.manager=true \
  -Dtests.locale=lg-UG \
  -Dtests.timezone=Africa/Juba \
  -Dcompiler.java=12 \
  -Druntime.java=11

Does not reproduce locally.

Excerpt from logs:

06:39:55   2> java.lang.AssertionError: expected:<0> but was:<16777216>
06:39:55         at __randomizedtesting.SeedInfo.seed([175DFFF16E9928FC:6655EB5329A51DB6]:0)
06:39:55         at org.junit.Assert.fail(Assert.java:88)
06:39:55         at org.junit.Assert.failNotEquals(Assert.java:834)
06:39:55         at org.junit.Assert.assertEquals(Assert.java:645)
06:39:55         at org.junit.Assert.assertEquals(Assert.java:631)
06:39:55         at org.elasticsearch.transport.netty4.SimpleNetty4TransportTests.tearDown(SimpleNetty4TransportTests.java:53)

[elasticmachine]

Pinging @elastic/es-core-infra (:Core/Infra/Core)

[alpar-t]

@przemekwitek I think we should mute the test on windows with something like assumeFalse(Constants.WIDOWS)

[przemekwitek]

Ok, I'll prepare a fix shortly.

[przemekwitek]

Another failure on 7.x:

Build | 20191022105837-FAD56C29
Log | https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+7.x+multijob-windows-compatibility/os=windows-2019/207/console
Build Scans | https://gradle-enterprise.elastic.co/s/h56kplfufmnfy

[przemekwitek]

Another instance:

Build | 20191022105802-5CDA2F31
Log | https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+7.x+multijob-windows-compatibility/os=windows-2016/207/console
Build Scans | https://gradle-enterprise.elastic.co/s/vh6r5tbo7yyhq

[przemekwitek]

Another instance:

Build | 20191022105811-393EEB9F
Log | https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+7.x+multijob-windows-compatibility/os=windows-2012-r2/207/console
Build Scans | https://gradle-enterprise.elastic.co/s/e7xuhufkojecc

[williamrandolph]

This may relate to a bug from #47384, which only happened with a Java 8 runtime (which is why it failed on 7.x but not master). In that case, we could be more specific in what we muted. For example, in JvmErgonomicsTests, we use:

        assumeFalse(System.getProperty("os.name").startsWith("Windows") && JavaVersion.majorVersion(JavaVersion.CURRENT) == 8);

See the specific issue's description in this comment: #47384 (comment)

EDIT: I'm not sure this is the same issue, after a closer look, but it seems related.

EDIT 2: I'm quite wrong, apologies for the noise. This affects the work I've been doing, not the other way around.

[Tim-Brooks]

I think this has to do with dirty state from a prior test. Netty holds a static allocator which if touched will allocate memory. In this test we are asserting the allocator is empty. This assertion was mainly a sanity check and I think was not well thought out on my part (requires all related test to cooperate).

I opened #48356 to remove this assertion.