Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EQL: Add support for existing functions #51556

Closed
18 tasks done
rw-access opened this issue Jan 28, 2020 · 3 comments
Closed
18 tasks done

EQL: Add support for existing functions #51556

rw-access opened this issue Jan 28, 2020 · 3 comments
Assignees
Labels
:Analytics/EQL EQL querying Team:QL (Deprecated) Meta label for query languages team

Comments

@rw-access
Copy link
Contributor

rw-access commented Jan 28, 2020

We need to add support for the subset of functions that EQL supports. Some of these may already exist from SQL, and we may need to create additional ones.

The full list is below:

switch (functionName) {
case "add":
case "between":
case "cidrMatch":
case "concat":
case "divide":
case "endsWith":
case "indexOf":
case "length":
case "match":
case "modulo":
case "multiply":
case "number":
case "startsWith":
case "string":
case "stringContains":
case "substring":
case "subtract":
case "wildcard":
break;

Math functions were created before EQL had math operators. These should be easy to do, and can probably be done together

Tracking remaining functions to be implemented

@rw-access rw-access added the :Analytics/EQL EQL querying label Jan 28, 2020
@rw-access rw-access self-assigned this Jan 28, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/EQL)

@costin
Copy link
Member

costin commented Mar 18, 2020

I have updated the initial description with check boxes, as we go through the functions once #53688 gets merged, we should mark them as done and indicate the relevant ticket.

I think the string functions are the first ones to be addressed as they are widely used. The operators one can be easily promoted into functions and so I would do them last as there is a workaround for them.

@costin
Copy link
Member

costin commented May 14, 2020

Looks like this can be closed, with #54568 as a follow-up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/EQL EQL querying Team:QL (Deprecated) Meta label for query languages team
Projects
None yet
Development

No branches or pull requests

4 participants