Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reindex and friends: don't scroll if limit is smaller than scroll #54270

Closed
nik9000 opened this issue Mar 26, 2020 · 2 comments · Fixed by #81654
Closed

Reindex and friends: don't scroll if limit is smaller than scroll #54270

nik9000 opened this issue Mar 26, 2020 · 2 comments · Fixed by #81654
Assignees
Labels
:Distributed Indexing/Reindex Issues relating to reindex that are not caused by issues further down Team:Distributed Meta label for distributed team (obsolete)

Comments

@nik9000
Copy link
Member

nik9000 commented Mar 26, 2020

I wonder if we could avoid adding the scroll to the search that reindex uses if the size of the reindex (or update_by_query or delete_by_query) is less than the scroll size. Or maybe scroll could do this all on its own if there aren't any results after the first set. I'm not sure if it has that information. But I'm fairly sure reindex and fiends could make this call up front.

@nik9000 nik9000 added the :Distributed Indexing/Reindex Issues relating to reindex that are not caused by issues further down label Mar 26, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/Reindex)

@nik9000 nik9000 changed the title Reindex and friend: don't scroll if limit is smaller than scroll Reindex and friends: don't scroll if limit is smaller than scroll Mar 26, 2020
@rjernst rjernst added the Team:Distributed Meta label for distributed team (obsolete) label May 4, 2020
@henningandersen
Copy link
Contributor

This sounds like a good idea, except for the cases affecting #63671, for instance if conflicts=proceed, we will need to open the scroll regardless, since the expectation is that we will update/delete/reindex max_docs docs if we can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Indexing/Reindex Issues relating to reindex that are not caused by issues further down Team:Distributed Meta label for distributed team (obsolete)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants