Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EQL: case sensitivity aware integration testing #56754

Closed
astefan opened this issue May 14, 2020 · 3 comments · Fixed by #58624
Closed

EQL: case sensitivity aware integration testing #56754

astefan opened this issue May 14, 2020 · 3 comments · Fixed by #58624
Assignees
Labels
:Analytics/EQL EQL querying >enhancement Team:QL (Deprecated) Meta label for query languages team >test Issues or PRs that are addressing/adding tests

Comments

@astefan
Copy link
Contributor

astefan commented May 14, 2020

With the addition of case_sensitivity request parameter, we should consider integration testing infra supporting it, as well, so that tests work no matter the value of this parameter.

@astefan astefan added >enhancement >test Issues or PRs that are addressing/adding tests :Analytics/EQL EQL querying labels May 14, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-ql (:Query Languages/EQL)

@elasticmachine elasticmachine added the Team:QL (Deprecated) Meta label for query languages team label May 14, 2020
@costin
Copy link
Member

costin commented May 21, 2020

Tagging @rw-access as well - not sure what's the best way forward. We could either end up with a different test suite so essentially there's one test for case sensitivity and another for the insensitive part. Or we can add dedicated tests inside the same test suite and based on a convention (such as test name or some sort of flag), some test will be skipped or picked up.

@rw-access
Copy link
Contributor

I added case sensitivity on/off flags to the Python TOML tests as part of the backport process. I just need to pull them into this repo. We may need to add more individual tests, but I think that should be sufficient for our testing. Unless there are other things I'm not anticipating

Here's an example of a test
https://github.com/endgameinc/eql/blob/master/eql/etc/test_queries.toml#L196

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/EQL EQL querying >enhancement Team:QL (Deprecated) Meta label for query languages team >test Issues or PRs that are addressing/adding tests
Projects
None yet
5 participants