Remove deprecation indexing code from 7.10 #63942
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It will be re-added once it is possible to mark a data stream as hidden, and to not rely on the standard logs template.
pugnascotia
added
>non-issue
:Core/Infra/Logging
Collaborator
|
Pinging @elastic/es-core-infra (:Core/Infra/Logging) |
Contributor
|
@pugnascotia - would it make more sense to leave the code in the pipeline, but disable the ability to enable it ? (kinda like a feature flag ?) It would also allow the code to be closer in sync with master. EDIT: on second thought since the branch has already been cut this probably makes the most sense. Kinda like it never made the cut for 7.10. The tests still run on master and 7.x and just await a change. We just need to be careful w.r.t timing of the 7.11 branch so we won't need to pull it from there too. |
Contributor
|
Also, once this lands you will want to remove the version label from the original PR so it does not get picked up via the release notes. |
This was referenced Oct 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deprecation indexing code was writing to a regular data stream, and it is not yet possible to hide a data stream or prefix it with a period. This functionality we be re-added once it is possible to mark a data stream as hidden, and also to not rely on the standard logs template since that can be disabled.
cc @elasticdog