Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EuiSwitch needs aria-labelledby to connect checkbox with label #1027

Closed
cjcenizal opened this issue Jul 18, 2018 · 2 comments
Closed

EuiSwitch needs aria-labelledby to connect checkbox with label #1027

cjcenizal opened this issue Jul 18, 2018 · 2 comments
Labels
accessibility

Comments

@cjcenizal
Copy link
Contributor

In other words, the screen-reader should announce the label content when the switch is focused. This will fix elastic/kibana#19128.
@cchaos
Copy link
Contributor

cchaos commented Jul 19, 2018

Currently EuiSwitch will connect the label with the checkbox so long as you pass an ID. However, right now an ID is not required so it is possible to not have id and for connections. There's an old PR #779 that is supposed to create an ID if one isn't provided – the same way we handle id's in EuiFormRow.

@cjcenizal
Copy link
Contributor Author

Awesome! That PR will close out this issue once it's in and we upgrade.

@snide snide mentioned this issue Jul 19, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accessibility
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cchaos @cjcenizal