Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EuiSearchBar controlled input breaks in React 16.4 #1152

Closed
bevacqua opened this issue Aug 29, 2018 · 1 comment
Closed

EuiSearchBar controlled input breaks in React 16.4 #1152

bevacqua opened this issue Aug 29, 2018 · 1 comment
Assignees

Comments

@bevacqua
Copy link
Contributor

You can verify with the docs as we just have with @chandlerprall

@chandlerprall
Copy link
Contributor

16.4 fixed a bug around getDerivedStateFromProps where that function is now called after a component's own setState, which is interrupting the search bar's flow to notify the controlling parent of a change.

@bevacqua also discovered that a controlled search bar blows up if provided an invalid query.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants