-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiBasicTable] Default action items should allow for dynamic names & descriptions #1401
Comments
We're going to take another look at tables & their data as the TypeScript refactor wraps up (or at least becomes more stable). That said, I would advocate for adding the |
Can I take this up? |
Is anyone still working on this issue ? I'd like to work on it. |
Sorry, we've been trying to keep up with these ownership requests and have been figuring out how we want to work with them. @shakti97 are you still interested in taking this? If not, I'll pass it on to @Gaurav-Punjabi |
Is anyone (shakti97 /Gaurav-Punjabi )still working on this issue ? I'd like to work on it. |
I am also finding out that we need this for the |
#3739 widened an action's |
👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment. |
This is still valid. |
👋 Hi there - this issue hasn't had any activity in 6 months. If the EUI team has not explicitly expressed that this is something on our roadmap, it's unlikely that we'll pick this issue up. We would sincerely appreciate a PR/community contribution if this is something that matters to you! If not, and there is no further activity on this issue for another 6 months (i.e. it's stale for over a year), the issue will be auto-closed. |
❌ Per our previous message, this issue is auto-closing after having been open and inactive for a year. If you strongly feel this is still a high-priority issue, or are interested in contributing, please leave a comment or open a new issue linking to this one for context. |
It appears that the
DefaultItemAction
can only accept hard-codedname
/description
values. While this isn't necessarily a bad thing, it is limiting because these actions cannot take advantage of any record-level information.For example, I was trying to add additional screen-reader context to some action buttons (elastic/kibana#27911), but the only way to do that is to create custom item actions, with a
render
function. This wasn't a ton of work, but I'm wondering if this is going to become a more common problem across Kibana, where action icons will need additional context in order to be useful to people using screen readers. If so, then the usefulness of theDefaultItemAction
will be reduced, because it can't provide that context currently.Proposal
Similar to the
available
andrender
functions of custom action columns, I propose that thename
anddescription
fields of theDefaultItemAction
s be updated to accept either astring
or a function of the form(record) => string
.The text was updated successfully, but these errors were encountered: