Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve outside click and focus trap handing of EuiNavDrawer #1712

Closed
ryankeairns opened this issue Mar 11, 2019 · 4 comments
Closed

Improve outside click and focus trap handing of EuiNavDrawer #1712

ryankeairns opened this issue Mar 11, 2019 · 4 comments
Labels

Comments

@ryankeairns
Copy link
Contributor

ryankeairns commented Mar 11, 2019

The one last thing I saw that was odd is that in mobile screen sizes, clicking the white area of the flyout closes the whole sidebar. It doesn't do this in larger breakpoints.

I think there is something a little off with how the OutsideClickDetector is being enabled/disabled by the mobile menu button. This was becoming apparent when I was trying to fix up the 'toggle flyout if you click/touch the same icon again'. As I dug into it, it felt like a thing that would make for a follow-up PR as it touches logic in a few places.

This issue could likely be addressed along with #1713

Originally posted by @ryankeairns in #1701 (comment)

@cchaos cchaos changed the title Improve the mobile menu toggling Improve outside click handing of EuiNavDrawer Mar 12, 2019
@cchaos
Copy link
Contributor

cchaos commented Mar 12, 2019

Edited title since it's an all around problem, not just mobile specific.

@cchaos cchaos changed the title Improve outside click handing of EuiNavDrawer Improve outside click and focus trap handing of EuiNavDrawer Mar 12, 2019
@cchaos
Copy link
Contributor

cchaos commented Mar 12, 2019

Also including focus trap on this one.

@seeruk
Copy link
Contributor

seeruk commented May 1, 2020

Not sure if this'll be related to this issue, but there's something odd going on right now in the latest version of EUI where if I lock the NavDrawer, then unlock it, it doesn't detect the outside clicks and close the NavDrawer. Maybe something caused by the TypeScript migration?

Edit: I think I can see the issue actually, will submit a PR.

@cchaos
Copy link
Contributor

cchaos commented Sep 18, 2020

This component is being deprecated in favor of EuiCollapsibleNav

@cchaos cchaos closed this as completed Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants