Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: babel/proptypes-from-ts-props fails #1757

Closed
PhilippBaranovskiy opened this issue Mar 22, 2019 · 6 comments
Closed

Build: babel/proptypes-from-ts-props fails #1757

PhilippBaranovskiy opened this issue Mar 22, 2019 · 6 comments

Comments

@PhilippBaranovskiy
Copy link
Contributor

It fails on the pre-commit hook where the summary of all failing tests is as the following one:

FAIL scripts/babel/proptypes-from-ts-props/index.test.js (6.248s)
  ● proptypes-from-ts-props › proptype generation › type and interface resolving › external references › local references › resolves to directory index files

    Test case should only try to read file unknown/common/index.ts

      1695 |                         readFileSync: filepath => {
      1696 |                           if (filepath !== path.resolve(process.cwd(), 'common/index.ts')) {
    > 1697 |                             throw new Error('Test case should only try to read file unknown/common/index.ts');
           |                                   ^
      1698 |                           }
      1699 |
      1700 |                           return Buffer.from(`

the next one is:

● proptypes-from-ts-props › proptype generation › type and interface resolving › external references › local references › resolves types exported without an import

    Test tried to import from C:\Users\Filipp_Baranovskii\Desktop\foo

and

 ● proptypes-from-ts-props › remove types from exports › removes type exports from ExportNamedDeclaration with a source

    Test tried to import from C:\Users\Filipp_Baranovskii\Desktop\eui\foo

Also it is referrences to 'foo' directory which is on an upper level as eui project directory (in my case Desktop/foo) -- I'm not sure why it is doing so/

@PhilippBaranovskiy
Copy link
Contributor Author

hi @chandlerprall, do you have some ideas?

@PhilippBaranovskiy
Copy link
Contributor Author

In the meantime I've used --no-verify flag to pass that step and check on CI whether it is code related bug or that I run it on Windows.

@thompsongl
Copy link
Contributor

Looks like you're on Windows, so it's possible that #1753 relevant

@PhilippBaranovskiy
Copy link
Contributor Author

@thompsongl that issue is written by @chandlerprall as a result of our common attempts to run it.
So, he provides there necessary steps to get round that issue. However, that issue and this one are about different problems, unfortunately.

So, I still don't know how to solve that.

@PhilippBaranovskiy
Copy link
Contributor Author

Seems as it's Windows only related as the PR passes the CI checking: #1758

@chandlerprall
Copy link
Contributor

Thanks for reporting! I'll make sure to address this when looking at #1753. I'm going to close this issue but add the problem to the existing Windows issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants