Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow superdatepicker to be disabled #2081

Closed
stacey-gammon opened this issue Jun 28, 2019 · 7 comments · Fixed by #2139
Closed

Allow superdatepicker to be disabled #2081

stacey-gammon opened this issue Jun 28, 2019 · 7 comments · Fixed by #2139

Comments

@stacey-gammon
Copy link
Contributor

Would love to make it disabled for the case of per panel time ranges, when the "inherited" toggle is on.

Screen Shot 2019-06-28 at 2 54 47 PM

@cchaos
Copy link
Contributor

cchaos commented Jul 12, 2019

@stacey-gammon Will this still block you even with the design that doesn't include the toggle?

@stacey-gammon
Copy link
Contributor Author

Oh gosh, I'm sorry, I totally glossed over that change! You are right, shouldn't need this in that case. Want me to close or just unlabel urgent?

@cchaos
Copy link
Contributor

cchaos commented Jul 12, 2019

I'll unlabel it, but it might still be a nice to have.

@cchaos cchaos removed the :urgent: label Jul 12, 2019
@chandlerprall
Copy link
Contributor

@cchaos we probably want a quick design pass on how the date picker should look / communicate that it is disabled

@cchaos cchaos assigned cchaos and unassigned cchaos Jul 17, 2019
@cchaos
Copy link
Contributor

cchaos commented Jul 17, 2019

It should just make the whole input look like out disabled inputs.

Screen Shot 2019-07-17 at 12 44 02 PM

Hopefully it's all hooked up to the right layout components that it should get those styles.

@chandlerprall
Copy link
Contributor

Should the disabled state prevent the datetime popover from opening, or should it open but all its controls be disabled?

@cchaos
Copy link
Contributor

cchaos commented Jul 18, 2019

If disabled=true is added to the EuiSuperDatePicker at the top level, it should disable everything from opening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants