Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiSideNav] Alternative display styles #2334

Closed
jfsiii opened this issue Sep 12, 2019 · 6 comments
Closed

[EuiSideNav] Alternative display styles #2334

jfsiii opened this issue Sep 12, 2019 · 6 comments

Comments

@jfsiii
Copy link

jfsiii commented Sep 12, 2019

Brought over from #2213

If we were doing it against EuiSideNav we'd likely add a new prop called display with an enum that included the new format alongside a default value for the current one. That would allow us to have more styles later if needed. You'd just want to document the alternative display in the EuiSideNav docs. The rest is likely some CSS and some consideration on whether this menu, like the current one accepts nesting.

-- #2213 (comment)

Collapsed

Screen Shot 2019-09-12 at 11 20 25 AM

Expanded

Installed

@hbharding
Copy link
Contributor

Hey @jfsiii - I'd be happy to try and take this on as my first EUI contribution.

@snide I might ping you later to find a time to meet so I know how to get started, maybe next week. I think we have some reading material on this, but i'll probably have some questions about the process along the way.

@hbharding hbharding self-assigned this Sep 12, 2019
@snide
Copy link
Contributor

snide commented Sep 12, 2019

@hbharding LET'S DO IT. I think this is totally doable on the design side. It should be mostly CSS and I can walk you through stuff. If you want, I don't mind pairing through it. Just schedule something on my cal.

@cchaos
Copy link
Contributor

cchaos commented Mar 27, 2020

@hbharding Is this still a valid feature request? Not sure if you've changed your design for this or if you still need it.

@hbharding
Copy link
Contributor

Hey! Sorry for the delay. Yeah, we still intend to do this, but it hasn't been a priority. In the meantime we're using a stacked list of EuiLinks. I'm wrapping up the remaining designs for Ingest manager this week, and intend to start contributing to the codebase so that it matches the designs. Let's touch base next week. Ideally we can get this in for 7.8, which we're calling our "alpha" release.

@cchaos cchaos changed the title EuiSideNav: Alternative display styles [EuiSideNav] Alternative display styles Sep 20, 2020
@github-actions
Copy link

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@hbharding
Copy link
Contributor

no longer relevant / needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants