Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve BasicTable <caption> text #2336

Closed
alisonelizabeth opened this issue Sep 12, 2019 · 2 comments · Fixed by #2782
Closed

Improve BasicTable <caption> text #2336

alisonelizabeth opened this issue Sep 12, 2019 · 2 comments · Fixed by #2782
Assignees

Comments

@alisonelizabeth
Copy link

Currently, the BasicTable component renders a caption with the text "Below is a table of X items."

default="Below is a table of {itemCount} items."

This isn't ideal if a page has multiple tables. It would be great if this text could be configurable or if the default could provide more context.

Suggested text from @barlowm:

"Below is the <table_name> table containing <number_of_visible_items> rows out of <number_of_total_items_if_multiple_pages>."

Related issue: elastic/kibana#43842

@myasonik
Copy link
Contributor

Also, captions have role caption added to them which is not allowed and not officially supported.

(Search for "caption" on this W3C page to verify. Can also see the violation when running axe.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants