Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table sort styling needs love #268

Closed
snide opened this issue Jan 8, 2018 · 11 comments
Closed

Table sort styling needs love #268

snide opened this issue Jan 8, 2018 · 11 comments

Comments

@snide
Copy link
Contributor

snide commented Jan 8, 2018

Fix sort arrows styling. Right now they're a bit unclear.

cc @uboness

@cchaos
Copy link
Contributor

cchaos commented Jan 8, 2018

This is what I came up with in the Sketch libraries, but it's up for debate.

screen shot 2018-01-08 at 15 18 50 pm

@uboness
Copy link
Contributor

uboness commented Jan 8, 2018

@cchaos that's definitely better than the current UI...

throwing it out there (have no idea how it'll end up looking... but lets try...)... what if we keep the "shadowed" sortable and also show it as a sort of a background for the current active sort... something along the line of:

sorted

not sure it works... but I guess what I'm trying to create here is more of a consistent view between the sortables columns and the currently sorted one. I think it's quite common to see this with a slightly different design (which I'm not sure fits in ours):

common

@snide
Copy link
Contributor Author

snide commented Jan 9, 2018

Maybe something like...

I like separating the icon usage a bit so it's a bit more distinct which of them is on. Otherwise you are trying to read a mono color on a 8px area.

@uboness
Copy link
Contributor

uboness commented Jan 9, 2018

I like this one:
screen shot 2018-01-09 at 01 18 46

not too crazy about this one:

screen shot 2018-01-09 at 01 19 18

would it work to have only the arrow head here? a la:

screen shot 2018-01-09 at 01 19 18

(only properly designed :))

@snide
Copy link
Contributor Author

snide commented Jan 9, 2018

Embracing @cchaos' bolds.

@cchaos
Copy link
Contributor

cchaos commented Jan 9, 2018

To signify direction, I lean towards arrows. We use the carets (arrowhead) to signify dropdowns

screen shot 2018-01-08 at 20 24 55 pm

and I see the double caret or double triangle used for select boxes

screen shot 2018-01-08 at 20 26 09 pm

It would be nice if we could stick with the full arrows (at least for the sorted version).

@cchaos
Copy link
Contributor

cchaos commented Jan 9, 2018

I got to thinking more on this, and I keep coming back to the same question.

Do we really need to signify that each column is sortable?

How often are there actually going to be columns that aren't sortable? Is it just an actions column? Is it enough to the user to just no have the mouse change on hover and not have it focusable if it can't be sorted?

I'm find that they can just start cluttering the header when you start getting a lot of them in one table. For example:

screen shot 2018-01-08 at 20 38 59 pm

or

screen shot 2018-01-08 at 20 39 55 pm

vs

screen shot 2018-01-08 at 20 39 32 pm

and

screen shot 2018-01-08 at 20 42 46 pm

@snide
Copy link
Contributor Author

snide commented Jan 9, 2018

I tend to agree. I'm OK removing um as long as we have proper hover states in there for the active ones.

@uboness
Copy link
Contributor

uboness commented Jan 9, 2018

+1 on removing it now... the cleaner the better... we can always add something later if we find the need to

@cchaos
Copy link
Contributor

cchaos commented Jan 9, 2018

👍

@cjcenizal
Copy link
Contributor

How often are there actually going to be columns that aren't sortable? Is it just an actions column?

Good point! If all table headers are sortable then "sortable" signifiers are moot. Let's keep an eye on what engineers experience in practice to make sure it jibes with theory.

@snide snide closed this as completed Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants