-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Table sort styling needs love #268
Comments
@cchaos that's definitely better than the current UI... throwing it out there (have no idea how it'll end up looking... but lets try...)... what if we keep the "shadowed" sortable and also show it as a sort of a background for the current active sort... something along the line of: not sure it works... but I guess what I'm trying to create here is more of a consistent view between the sortables columns and the currently sorted one. I think it's quite common to see this with a slightly different design (which I'm not sure fits in ours): |
Embracing @cchaos' bolds. |
I got to thinking more on this, and I keep coming back to the same question.
How often are there actually going to be columns that aren't sortable? Is it just an actions column? Is it enough to the user to just no have the mouse change on hover and not have it focusable if it can't be sorted? I'm find that they can just start cluttering the header when you start getting a lot of them in one table. For example: orvs and |
I tend to agree. I'm OK removing um as long as we have proper hover states in there for the active ones. |
+1 on removing it now... the cleaner the better... we can always add something later if we find the need to |
👍 |
Good point! If all table headers are sortable then "sortable" signifiers are moot. Let's keep an eye on what engineers experience in practice to make sure it jibes with theory. |
Fix sort arrows styling. Right now they're a bit unclear.
cc @uboness
The text was updated successfully, but these errors were encountered: