Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EUI release(s) for 7.6 #2751

Closed
1 of 6 tasks
thompsongl opened this issue Jan 10, 2020 · 14 comments
Closed
1 of 6 tasks

EUI release(s) for 7.6 #2751

thompsongl opened this issue Jan 10, 2020 · 14 comments
Assignees
Labels

Comments

@thompsongl
Copy link
Contributor

thompsongl commented Jan 10, 2020

Provided eui@18.0.0 does not merge to kibana@7.x before 7.6 FF, we'll plan on the following:

If the new solution icons are not available by Tuesday(ish):

  • Create the eui@18.2.0 release
  • Create a eui@17.5.0 backport release with:
    • New solution icons (eui@18.2.0)
  • Update kibana with eui@17.5.0 (including 7.x branch)

Other commits to backport:

@thompsongl thompsongl self-assigned this Jan 10, 2020
@thompsongl
Copy link
Contributor Author

Anything else we need to backport, @snide @myasonik ?

@myasonik
Copy link
Contributor

We also want to get as many of the a11y fixes into 7.6 as possible (we're going to be redoing the VPAT against 7.6 and a few other a11y things will peg off 7.6 as well).

I went through the changelog and only could find #2455 as an a11y improvement even though I could have sworn there were others... (Maybe they all went in earlier?)

@thompsongl
Copy link
Contributor Author

I believe #2455 depends upon work in #2686, which is the reason that 18.0.0 is having trouble getting into Kibana //cc @chandlerprall

@cchaos
Copy link
Contributor

cchaos commented Jan 11, 2020

I think that if we get the latest master into a release and update the Kibana PR, then I can do all the hex value replacements directly in that PR and 🤞 we could get it into 7.6

@chandlerprall
Copy link
Contributor

Last rebase of the 18.0 PR against master breaks Kibana startup (?)(!). Working through that today, and even if it's ready Monday morning (which is my intent) it still needs review and approvals, so I don't imagine it will make the 7.6 cutoff via a [Kibana] backport.

An EUI backport to our 17.x line, however, should be able to make a direct merge into Kibana 7.x

@snide
Copy link
Contributor

snide commented Jan 11, 2020

I think it will be very tight for icons by Tuesday. I would assume we will have post FF release with those. Please don't work on the weekend to get 18.0 in. It either happens on monday/tuesday or it doesn't, but there's nothing in there super duper crazy that has me worried about cascading breaks. This wouldn't be the first time we've put an EUI release into Kibana post feature freeze, and as long as we're not talking many days past, let's not rush this. I'll grab us time if we need, but lets use work time, not weekend time.

@chandlerprall
Copy link
Contributor

Kibana PR for EUI 18.0.0 is green; moved out of draft and ready for review (thanks to @cchaos for helping clear it up).

@snide
Copy link
Contributor

snide commented Jan 13, 2020

@thompsongl is going to prep 18.1.0 based upon master and @chandlerprall's upgrade PR. He'll check out the ease of getting an upgrade in. If it looks hard, the current plan is to make an 18.0.x series to backport some smaller nav only fixes. Likely there will be a minor icon PR that will need a backport after these.

@thompsongl
Copy link
Contributor Author

Upgrading Kibana to 18.1.0 is looking to be smooth. Nearly all changes are just hex/color updates in snapshot tests.

@thompsongl
Copy link
Contributor Author

Update

18.0.0 merged in time and 18.2.0 contains only commits that would have been backported otherwise. Therefore, upgrading Kibana to 18.2.0 is in the works and there will likely not be a backport to 7.6 later this week. Any solution icons will be added ASAP, but in a normal release targeting 7.7

@cchaos
Copy link
Contributor

cchaos commented Jan 14, 2020

Both 18.0 and 18.2 will not be backported to 7.6?

@chandlerprall
Copy link
Contributor

chandlerprall commented Jan 14, 2020

18.0 and 18.2 should be in the 7.x branch before 7.6 is cut, so included but not backports.

Edit: above, original message wasn't quite right

18.0 and 18.2 have all EUI commits intended for 7.6. EUI will not need a backport release, but both 18.0 and 18.2 are being backported to 7.x branch to make the 7.6 cut.

@thompsongl
Copy link
Contributor Author

Yes, @chandlerprall is correct, sorry for confusion.

@thompsongl
Copy link
Contributor Author

✅ master: elastic/kibana#54786
✅ 7.x: elastic/kibana#54869

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants