Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EuiFieldSearch's manual call to onChange doesn't match intent #2763

Closed
chandlerprall opened this issue Jan 15, 2020 · 0 comments · Fixed by #2764
Closed

EuiFieldSearch's manual call to onChange doesn't match intent #2763

chandlerprall opened this issue Jan 15, 2020 · 0 comments · Fixed by #2764
Assignees
@chandlerprall

Comments

@chandlerprall
Copy link
Contributor

This change does not respect the contract of the onChange handler that expects a React.ChangeEvent

Screen Shot 2020-01-15 at 12 50 05

It caused a regression bug on our side (elastic/kibana#54810), we can quickly fix it but it might have caused a regression on other consumers so it would be better to change it here. @andreadelrio

Originally posted by @sebelga in #2723
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chandlerprall chandlerprall

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix EuiFieldSearch's onChange call so it is always called with the Event chandlerprall/eui
1 participant
@chandlerprall