Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use chroma-js for all color parsing and conversion #2804

Open
thompsongl opened this issue Jan 30, 2020 · 6 comments
Open

Use chroma-js for all color parsing and conversion #2804

thompsongl opened this issue Jan 30, 2020 · 6 comments

Comments

@thompsongl
Copy link
Contributor

Now that EUI has heavy reliance on chroma-js (color palette creation, color contrast calculations for a11y), other custom methods should likely be deprecated and removed.

Such custom methods are part of the public API, so we need to either schedule for deprecation and removal, or convert them to use chroma-js for consistency.

Methods in the EUI public API:

hexToHsv,
hexToRgb,
hsvToHex,
hsvToRgb,
rgbToHex,
rgbToHsv,
isValidHex
@thompsongl
Copy link
Contributor Author

isValidHex at the very least should remain part of the API, although it should change to use chroma.valid for consistency.

@github-actions
Copy link

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@github-actions
Copy link

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@github-actions
Copy link

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@github-actions
Copy link

👋 Hi there - this issue hasn't had any activity in 6 months. If the EUI team has not explicitly expressed that this is something on our roadmap, it's unlikely that we'll pick this issue up. We would sincerely appreciate a PR/community contribution if this is something that matters to you! If not, and there is no further activity on this issue for another 6 months (i.e. it's stale for over a year), the issue will be auto-closed.

Copy link

👋 Hi there - this issue hasn't had any activity in 6 months. If the EUI team has not explicitly expressed that this is something on our roadmap, it's unlikely that we'll pick this issue up. We would sincerely appreciate a PR/community contribution if this is something that matters to you! If not, and there is no further activity on this issue for another 6 months (i.e. it's stale for over a year), the issue will be auto-closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants