Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align styling of inline code snippets #289

Closed
formgeist opened this issue Jan 11, 2018 · 2 comments
Closed

Align styling of inline code snippets #289

formgeist opened this issue Jan 11, 2018 · 2 comments
Assignees

Comments

@formgeist
Copy link
Contributor

Noticed that the styling we use for inline code snippets don't exactly follow the same style as on elastic.co, so this becomes evident when using the setup instructions in Kibana, that the styling is quite different.

Example of the current EUI styling
screenshot 2018-01-11 11 58 21

Example of the elastic.co styling
screenshot 2018-01-11 11 58 56

Wondering if there's consensus to align the two for consistency (and brand), or at least create another style prop for having a highlighted version which could be used for i.e. setup instructions, so there's an option for the devs to use which they prefer.

Thoughts?

@elastic/kibana-design

@snide
Copy link
Contributor

snide commented Jan 11, 2018

We chatted this up in our design meeting. Decision was that EuiCode should...

  • Use the full font size.
  • Maybe add some more padding horizontally.
  • Color was fine.

I can take this on.

@snide
Copy link
Contributor

snide commented Jan 31, 2018

Our side of this was merged.

@snide snide closed this as completed Jan 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants