Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar does not scroll on mobile #3143

Closed
cpmoore opened this issue Mar 21, 2020 · 7 comments
Closed

Sidebar does not scroll on mobile #3143

cpmoore opened this issue Mar 21, 2020 · 7 comments
Labels

Comments

@cpmoore
Copy link

cpmoore commented Mar 21, 2020

When viewing kibana using a mobile browser I am unable to scroll the sidebar. I’m opening this issue here instead of the Kibana repo as I assume it’s an issue with the sidebar component.

I have a video of the issue but I am unable to upload it currently. I have attached a screenshot of the issue instead, to show you how many options I have.

5F049A1D-82B4-4413-B18A-031A0DA3DA75

@chandlerprall
Copy link
Contributor

Can reproduce in the EUI docs, using Chrome on Android. I added 20 more <EuiNavDrawerGroup listItems={this.analyzeLinks} /> lines to src-docs/src/views/nav_drawer/nav_drawer.js and can scroll on desktop but not on mobile. Can also reproduce this in Desktop Chrome's device "emulation".

@lokeshrana9999
Copy link
Contributor

@chandlerprall, Sorry about asking for assignment of this issue after initiating pr. Please assign this to me and review #3174.

@chandlerprall
Copy link
Contributor

@lokeshrana9999 thank you for the PR! As a rule, we are not assigning issues to community contributors so I am leaving this unassigned.

We sometimes reserve larger projects or ones that are core to our roadmap or design to be done internally. In these cases we mark these issues as assigned to a person using Github. We do not, as a policy, assign issues to community members. If you find an issue that is not assigned, assume that you are welcome to work on it and can submit a pull request. Feel free to leave a comment to mark intent and avoid conflict.

https://github.com/elastic/eui/blob/master/CONTRIBUTING.md#how-we-assign-work-and-define-our-roadmap

@cchaos
Copy link
Contributor

cchaos commented Mar 26, 2020

Thanks for finding the root of the problem which seems to be stemming from the EuiFlexGroup's responsive property. Instead of overriding this in CSS, however, we should just make the EuiFlexGroup's instance be responsive=false at this line:

<EuiFlexGroup gutterSize="none">

@lokeshrana9999
Copy link
Contributor

Thanks for the input @cchaos, I have updated my PR related to this issue, please review it.
#3174

@anishagg17
Copy link
Contributor

@cchaos I think you forgot to close this issue

@cchaos
Copy link
Contributor

cchaos commented Mar 27, 2020

Fixed via #3174

@cchaos cchaos closed this as completed Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants