Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EuiContextMenuItem needs to accept arbitrary components as children #336

Closed
cjcenizal opened this issue Jan 26, 2018 · 1 comment
Closed

Comments

@cjcenizal
Copy link
Contributor

cjcenizal commented Jan 26, 2018

Based on use cases discovered in #250, we need to be able to support children such as:

  • EuiSwitch
  • EuiCheckbox
  • EuiRadioGroup

In these cases, tabbing to an item should move focus to the first focusable child. As long as a child of the item retains focus, this item should retain the "focused state" blue background.

I don't think the item should be a focus trap. In other words, tabbing through a radio group and then beyond the last radio should move focus to the next EuiContextMenuItem.

CC @uboness

@cjcenizal cjcenizal self-assigned this Jan 26, 2018
@cjcenizal cjcenizal removed their assignment Jun 18, 2018
@chandlerprall
Copy link
Contributor

Closing this issue. The design team is doing housekeeping against our issues and closing items without much recent activity. Feel free to reopen if you still have issues or feel this is in error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants