Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconsider sideEffects designation #3397

Closed
thompsongl opened this issue Apr 28, 2020 · 0 comments · Fixed by #3805
Closed

Reconsider sideEffects designation #3397

thompsongl opened this issue Apr 28, 2020 · 0 comments · Fixed by #3805
Assignees
@chandlerprall
Labels
developer experience

Comments

@thompsongl
Copy link
Contributor

Per investigation in #3391, the package.json setting for sideEffects may be incorrect.

CSS has a side effect: "adding CSS to the DOM". You can't mark it as side-effect-free. Instead do this:

"sideEffects": [
  "*.css"
]

We may want to change to the code commented above.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chandlerprall chandlerprall

Labels
developer experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

enable webpack sideEffects for css and scss files chandlerprall/eui
2 participants
@chandlerprall @thompsongl