Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clear query button inconsistently displayed for search / EuiSearchBarProps #3488

Closed
jpcarey opened this issue May 15, 2020 · 2 comments · Fixed by #3497
Closed

clear query button inconsistently displayed for search / EuiSearchBarProps #3488

jpcarey opened this issue May 15, 2020 · 2 comments · Fixed by #3497

Comments

@jpcarey
Copy link

jpcarey commented May 15, 2020

Using the EuiInMemoryTable with search / EuiSearchBarProps, the clear query button does not display when the search state is externally provided.

image

To reproduce:
The "In-memory table with search and external state" example displays this issue. Just click any of the left side selectable cards, and the query will be updated. Add a space in the search bar and submit, and the clear query button will appear.

@thompsongl
Copy link
Contributor

A quick look before the issue was created showed that search_box uses defaultValue for query values, but field_search looks at value to determine whether to display the clear button. Just a little debug help for whoever takes this on.

@chandlerprall
Copy link
Contributor

Another bug with the controlled input, reproducible on the Controlled docs:

If a pre-built value is selected and the input then changed by the user, that same pre-built value won't reselect. This is likely a bug in the example docs and not EUI src.

pre select bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants