Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiSuggest] labelDisplay is not respected #4173

Closed
jen-huang opened this issue Oct 22, 2020 · 3 comments · Fixed by #4180
Closed

[EuiSuggest] labelDisplay is not respected #4173

jen-huang opened this issue Oct 22, 2020 · 3 comments · Fixed by #4180
Assignees
Labels

Comments

@jen-huang
Copy link
Contributor

Example CodeSandbox

When passing suggestions to EuiSuggest, labelDisplay: "expand" property is not respected. The suggestion items are always rendered with fixed CSS class.

@andreadelrio
Copy link
Contributor

Hi @jen-huang thanks for reporting. So I'm seeing two issues, first that labelDisplay is not getting passed to EuiSuggestItem when used on EuiSuggest. Second that in the Kibana issue you linked the problem is that the description is getting truncated. labelDisplay will only expand the label, it has no effect on the description. I'll put together a PR to try and come up with a solution to this.

@jen-huang
Copy link
Contributor Author

Thank you @andreadelrio!

@andreadelrio
Copy link
Contributor

@jen-huang a fix has just been merged into master. My suggestion for when it becomes available in Kibana is to pass descriptionDisplay="wrap" and labelWidth="40" (maybe try 30 too).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants