Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiSuggest] component has errors with TypeScript typing #4341

Closed
alexwizp opened this issue Dec 4, 2020 · 2 comments · Fixed by #5658
Closed

[EuiSuggest] component has errors with TypeScript typing #4341

alexwizp opened this issue Dec 4, 2020 · 2 comments · Fixed by #5658

Comments

@alexwizp
Copy link
Contributor

alexwizp commented Dec 4, 2020

We faced with difficulties while trying to use this component in typescript. This component implements the standard Input properties, but there is an error when trying to use them

image

At least value, placeholder, disabled props should be available

@thompsongl
Copy link
Contributor

I think the issue goes a bit deeper than the component types, although they do highlight the restrictions of EuiSuggest.
Currently, EuiSuggest is not set up to be a fully controlled form component. Passing value only works by accident (types aside), but I see the case where consumers would want to control the input.
We should make the changes to allow for full control.

@github-actions
Copy link

github-actions bot commented Jun 6, 2021

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants