Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix arrow coloring in popovers with context menus #45

Closed
snide opened this issue Oct 25, 2017 · 1 comment
Closed

Fix arrow coloring in popovers with context menus #45

snide opened this issue Oct 25, 2017 · 1 comment
Assignees
@snide

Comments

@snide
Copy link
Contributor

snide commented Oct 25, 2017

The popover arrows need to be more aware of context menu title in regards to color. Right now they'll always appear dark no matter the position or usage. I have this mostly working for popovers themselves, just need to rework it for context menus.

image
@snide snide self-assigned this Oct 25, 2017
@snide snide mentioned this issue Oct 25, 2017
Merged
@snide
Copy link
Contributor Author

snide commented Mar 9, 2018

This was the fault of using withTitle incorrectly.

@snide snide closed this as completed Mar 9, 2018
@snide snide mentioned this issue Mar 9, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snide snide

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@snide