Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiDataGrid] stripes in gridStyle alternates bewteen pages #4705

Closed
j-m opened this issue Apr 13, 2021 · 4 comments · Fixed by #5070
Closed

[EuiDataGrid] stripes in gridStyle alternates bewteen pages #4705

j-m opened this issue Apr 13, 2021 · 4 comments · Fixed by #5070
Assignees

Comments

@j-m
Copy link
Contributor

j-m commented Apr 13, 2021

Prior to virtualisation, the config

gridStyle={{
  stripes : true
}}

always started the first row of a page with a white background.
Now, the first row will alternate white/grey on odd/even pages respectively, as if the pattern were continuing across pages.

See also #4483

@j-m
Copy link
Contributor Author

j-m commented Apr 13, 2021

Also, if you don't update rows during onSort, the rows keep their background colour; so you could end up with multiple whites/greys in succession. For now, I'm just going to disable stripes

@chandlerprall
Copy link
Contributor

chandlerprall commented Apr 13, 2021

Second issue (background color) may be related to #4665

@j-m
Copy link
Contributor Author

j-m commented May 24, 2021

@chandlerprall Out of curiosity, why does the datagrid not have row wrappers?
Would solve this issue as well as #4401 #4474 #4483

@myasonik
Copy link
Contributor

It used to but virtualization broke it and we use a 3rd party library (react-window) to handle that for us.

So fixing the issue is either a matter of forking the repo or contributing upstream but either way we haven't had a chance to address it yet. As you can see with the issues piling up around rows, we clearly want and need to though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants