Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiPopover] Popover is placed above header (z-index) #4756

Closed
akaRem opened this issue Apr 26, 2021 · 5 comments
Closed

[EuiPopover] Popover is placed above header (z-index) #4756

akaRem opened this issue Apr 26, 2021 · 5 comments

Comments

@akaRem
Copy link

akaRem commented Apr 26, 2021

image
image

to reproduce:

or

@miukimiu
Copy link
Contributor

This issue visually looks like a bug but is not. In some situations, the popover can be very close to the top of a page and once we open it we can't read the content because it would slip underneath the EuiHeader.

Having the EuiPopover with a higher z-index than the EuiHeader can prevent this type of issue: #3398.

@miukimiu
Copy link
Contributor

I reponed the issue and added a discussion label because I think these two scenarios from #3398 could be prevented if both EuiPopover's were implemented with the anchorPosition set to "downCenter", "downLeft" or "downRight"

80552325-4ee4bd00-8994-11ea-802e-0c80e59af137 (1)

80552409-83f10f80-8994-11ea-94f5-a7601483e097

For example, nowadays in Kibana, the popover of the example above is positioned "downLeft".

Screenshot 2021-05-24 at 16 10 27

So lowering the EuiPopover z-index makes sense if we think no one is going to implement it close to the header with an anchor position that is not down.

@cchaos @myasonik @thompsongl any thoughts?

@cchaos
Copy link
Contributor

cchaos commented May 25, 2021

I talked offline with @miukimiu about this and how complicated it gets for consumers to remember the exact settings when their popover is near the header. Right now, at least the contents within the popover will always be visible no matter the placement and that's the main thing. Yes it looks funny when you scroll and the popover is above a fixed header. But I don't think this problem is easily solved unless we get a context wrapper that manages all the layered/fixed position/portalled elements.

@github-actions
Copy link

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@github-actions
Copy link

❌ We're automatically closing this issue due to lack of activity. Please comment if you feel this was done in error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants