Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement table footer in BasicTable and maybe MemoryTable #493

Closed
timroes opened this issue Mar 10, 2018 · 3 comments
Closed

Implement table footer in BasicTable and maybe MemoryTable #493

timroes opened this issue Mar 10, 2018 · 3 comments
Assignees

Comments

@timroes
Copy link
Contributor

timroes commented Mar 10, 2018

It would be nice to have a possibility for footers in tables (we would require that for table vis).

I see footers be possible in two different ways:

  • Define a column specific footer (e.g. via the column definition). That will be rendered as the footer below that column.
  • Often you might want to have an overall footer, that might span several columns, so I think it would be nice to have also the possibility to specify a table footer, that can use colspan.

Why are these needed?

  • They should properly render tfoot for better accessibility and semantics.
  • The footer needs different (font) styling, value formatting (i.e. not use the cell render function).
  • Not take part in any sorting or counting for pagination.
@lukeelmers
Copy link
Member

I can take a look at this as it's a prerequisite for elastic/kibana#16639

@lukeelmers lukeelmers self-assigned this Sep 7, 2018
@snide
Copy link
Contributor

snide commented Sep 7, 2018

@lukeelmers if you take this on, just pass a PR over to myself, @cchaos or @ryankeairns and we'll clean up any styling it needs. It's OK to pass it over functional without styling.

@lukeelmers
Copy link
Member

@snide Awesome -- will do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants