Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove EuiComboBox down arrow button from tab order #5024

Closed
cjcenizal opened this issue Aug 12, 2021 · 5 comments · Fixed by #5636
Closed

Remove EuiComboBox down arrow button from tab order #5024

cjcenizal opened this issue Aug 12, 2021 · 5 comments · Fixed by #5636

Comments

@cjcenizal
Copy link
Contributor

I don't think the accessibility of this component is improved by making this arrow button focusable, since you can tab into the component and use the down arrow and Esc to open and close the suggestions list, respectively. Keeping it in the tab order means that users need to hit Tab an extra time to exit the component. I'd consider it an accessibility improvement if we remove it from tab order.

image

@myasonik
Copy link
Contributor

Attaching to #2841 which mentions this

For whatever it's worth, the aria practices guidelines also exclude the down arrow

@github-actions
Copy link

github-actions bot commented Feb 9, 2022

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@github-actions
Copy link

❌ We're automatically closing this issue due to lack of activity. Please comment if you feel this was done in error.

@cjcenizal
Copy link
Contributor Author

Still valid

@1Copenut
Copy link
Contributor

@cjcenizal I'm going to add this to my work on #5636. Thanks for keeping it active.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants