Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiSuperSelect] value and generic discrepancy #5154

Closed
thompsongl opened this issue Sep 7, 2021 · 5 comments
Closed

[EuiSuperSelect] value and generic discrepancy #5154

thompsongl opened this issue Sep 7, 2021 · 5 comments

Comments

@thompsongl
Copy link
Contributor

thompsongl commented Sep 7, 2021

EuiSuperSelect accepts a generic to set the type of the value property (defaults to string), but there is an expectation (both in TypeScript and when setting the id attribute) that value is always a string.
Either value needs to be a string and we need to remove the generic, or we make the generic work and resolve the a11y/id problem by generating or coercing a value for id.

The latter makes more sense to me, as there is no valid technical reason that value cannot be an object of arbitrary shape.

@github-actions
Copy link

github-actions bot commented Mar 7, 2022

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@github-actions
Copy link

github-actions bot commented Sep 3, 2022

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@github-actions
Copy link

👋 Hi there - this issue hasn't had any activity in 6 months. If the EUI team has not explicitly expressed that this is something on our roadmap, it's unlikely that we'll pick this issue up. We would sincerely appreciate a PR/community contribution if this is something that matters to you! If not, and there is no further activity on this issue for another 6 months (i.e. it's stale for over a year), the issue will be auto-closed.

Copy link

❌ Per our previous message, this issue is auto-closing after having been open and inactive for a year. If you strongly feel this is still a high-priority issue, or are interested in contributing, please leave a comment or open a new issue linking to this one for context.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 19, 2024
@cee-chen
Copy link
Contributor

This was fixed by #7359 / #7362

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants