Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual regression tests to protect against accidental CSS side effects #521

Closed
cjcenizal opened this issue Mar 15, 2018 · 6 comments
Closed
Assignees
Labels
meta testing Issues or PRs that only affect tests - will not need changelog entries

Comments

@cjcenizal
Copy link
Contributor

cjcenizal commented Mar 15, 2018

Visual regression testing makes more sense in the UI Framework than inside of a consumer of EUI, e.g. Kibana, because regressions will be on a more granular scale and easier to address. Ideally we'd implement this using a tool which also supports cross-browser testing (here's a list of services we can consider). See https://blog.hichroma.com/why-design-systems-are-a-single-point-of-failure-ec9d30c107c2 for more background.

@cuff-links cuff-links self-assigned this Mar 20, 2018
@cuff-links
Copy link
Contributor

I will run with this.

@snide
Copy link
Contributor

snide commented Mar 20, 2018

@silne30 yeah! ❤️

@cuff-links cuff-links added meta testing Issues or PRs that only affect tests - will not need changelog entries labels Mar 20, 2018
@cuff-links
Copy link
Contributor

cuff-links commented Mar 20, 2018

Visual Regression Tests

  • Add WebDriver.io and drivers as dependencies.
    • WebDriver.io
    • wdio-visual-regression-service
    • GeckoDriver 1.10.0
    • Chromedriver 2.36
    • IE Driver (for IE 11)
  • Configuration

The webdriver.io team is not adding Jest support anymore. Honestly, it's not needed.

@cuff-links
Copy link
Contributor

cuff-links commented Apr 4, 2018

Had a mini-demo and here are some of the take away items for what's left.

- [ ] Issue with Chromedriver running locally. See issue

  • Using Selenium 3.4 until above lissted issue is fixed.
  • Add .png files and src-docs to be excluded from npm
  • Map each user in data_store.js to a different country.
    - [ ] Abstract the png baseline files to a submodule (or possibly even the entire test framework).
  • Create README.md to show how to write and run tests.

@christian-bromann
Copy link

Just leaving this here: webdriverio/webdriverio#2052 (comment) 😉

@cuff-links
Copy link
Contributor

Creating a JS script to run the tests (creating baselines and then rerunning). For CI, there will be a --destroy flag or --create-baseline flag to remove cached images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta testing Issues or PRs that only affect tests - will not need changelog entries
Projects
None yet
Development

No branches or pull requests

4 participants