Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiSuperDatePicker] Date formatting and i18n #5266

Closed
thompsongl opened this issue Oct 13, 2021 · 2 comments
Closed

[EuiSuperDatePicker] Date formatting and i18n #5266

thompsongl opened this issue Oct 13, 2021 · 2 comments

Comments

@thompsongl
Copy link
Contributor

The formatTimeString util will return string values that bypass i18n (now, Invalid Date).
Investigate how best to incorporate i18n.


I'd like to see this use i18n, but none of the other values from this function use it and it's unclear how we'd adjust the output.

I'll open a separate issue to explore; this doesn't need to be a blocker for this PR.

Originally posted by @thompsongl in #5263 (comment)

@github-actions
Copy link

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@thompsongl
Copy link
Contributor Author

Resolved by #5743

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant