-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiDataGrid] Vertical scroll becomes disabled with pagination and content change #5391
Comments
Can you post repro steps for latest Kibana main? I'm not able to get the "Paginate table" option to show up using the same sample data (web logs) and rows/columns/metrics that I'm seeing in your screenshot. |
@constancecchen the table pagination option is currently in PR. |
Oh perfect thanks! Checking that out now |
Sorry—I already added a workaround! In order to reproduce, check out this commit elastic/kibana@09a9e18 |
Ahhh hahaha I was just about to comment! FWIW your workaround is working perfectly 😂 |
Some maybe(?) unfortunate news - I still can't repro this on the linked commit in either Firefox or Chrome (edit: also tried Safari and it's working). Here's my repro steps + things tried:
Adding a screencap for completeness. repro.mp4Is it possible that #5313 (landed in EUI v40.1.0 and merged into Kibana main 18 days ago) fixed this issue? Although after looking at the timestamps on the PR/branch it's probably not super likely if y'all have merged main any time recently. CCing @chandlerprall for more ideas! |
I've followed the steps above to reproduce it from the specific commit. |
Sorry, I should have amended my comment before end of last week - @andrewctate reached out and helped me reliably create repro steps. Adding |
I tested the fix in #5400 against my local Kibana with the above issue and can confirmed it should be fixed in the next EUI release (approx ~2 weeks from now, as our most recent release/Kibana upgrade will not contain the fix). I'll try to remember to either remove your |
@constancecchen sounds good. Thank you for that quick turnaround! |
@andrewctate Apologies, with the holidays I 100% forgot to ping you! This fix should be in latest Kibana at this point, so feel free to remove your |
Thanks, @constancecchen ! Will do. |
I've managed to reproduce the issue in this Lens PR: elastic/kibana#118557
Found a previous similar issue #5131 about horizontal scrolling.
I'm attempting to isolate the bug to reproduce it in a clean sandbox, but it requires some layout effort to recreate a layout similar to Lens. Will update once created
The text was updated successfully, but these errors were encountered: