Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiDataGrid] Vertical scroll becomes disabled with pagination and content change #5391

Closed
dej611 opened this issue Nov 19, 2021 · 12 comments · Fixed by #5400
Closed

[EuiDataGrid] Vertical scroll becomes disabled with pagination and content change #5391

dej611 opened this issue Nov 19, 2021 · 12 comments · Fixed by #5400

Comments

@dej611
Copy link
Contributor

dej611 commented Nov 19, 2021

I've managed to reproduce the issue in this Lens PR: elastic/kibana#118557

Found a previous similar issue #5131 about horizontal scrolling.

pagination_scroll_issue

I'm attempting to isolate the bug to reproduce it in a clean sandbox, but it requires some layout effort to recreate a layout similar to Lens. Will update once created

@cee-chen
Copy link
Contributor

Can you post repro steps for latest Kibana main? I'm not able to get the "Paginate table" option to show up using the same sample data (web logs) and rows/columns/metrics that I'm seeing in your screenshot.

@drewdaemon
Copy link

@constancecchen the table pagination option is currently in PR.

@cee-chen
Copy link
Contributor

Oh perfect thanks! Checking that out now

@drewdaemon
Copy link

Sorry—I already added a workaround! In order to reproduce, check out this commit elastic/kibana@09a9e18

@cee-chen
Copy link
Contributor

Ahhh hahaha I was just about to comment! FWIW your workaround is working perfectly 😂

@cee-chen
Copy link
Contributor

cee-chen commented Nov 19, 2021

Some maybe(?) unfortunate news - I still can't repro this on the linked commit in either Firefox or Chrome (edit: also tried Safari and it's working). Here's my repro steps + things tried:

  • Setup
    • git checkout 09a9e18760bf0adc166432af3d975a91ed954443
    • git checkout -b test-repro-branch
    • git merge main (I wanted latest EUI to ensure most recent release/fixes)
    • yarn kbn bootstrap && yarn start
  • In Kibana
    • Logged in & added the Web Logs sample dataset
    • Went to Lens > Create Visualization
    • Selected kibana_sample_data_logs in the top left data view dropdown
    • Changed the Visualization Type to a Table
    • Changed the date filter to look at past week(s) to get enough data
    • Dragged the bytes field in the left column to the Metrics section in the right column
    • Dragged the @timestamp field in the left column to the Rows section in the right column
    • Clicked the paintbrush icon and toggled "Paginate table"
    • Dragged the extension.keywords field in the left column to the Columns section in the right column
    • At this point I had not seen any issues with the table becoming unscrollable.
  • Other things I tried
    • Toggling pagination on and off (no effect)
    • Adding more fields to the Columns section
    • Deleting fields from the Columns section

Adding a screencap for completeness.

repro.mp4

Is it possible that #5313 (landed in EUI v40.1.0 and merged into Kibana main 18 days ago) fixed this issue? Although after looking at the timestamps on the PR/branch it's probably not super likely if y'all have merged main any time recently. CCing @chandlerprall for more ideas!

@dej611
Copy link
Contributor Author

dej611 commented Nov 22, 2021

I've followed the steps above to reproduce it from the specific commit.
At first when dropping the extension.keywords into the Columns group, the scrolled working, but removing and re-adding it unlocked the bug.

@cee-chen
Copy link
Contributor

cee-chen commented Nov 22, 2021

Sorry, I should have amended my comment before end of last week - @andrewctate reached out and helped me reliably create repro steps. Adding @timestamp as a row and then adding extension.keywords as a second row helped me repro the issue 100%. I'm debugging this now and tracking down a solution!

@cee-chen
Copy link
Contributor

I tested the fix in #5400 against my local Kibana with the above issue and can confirmed it should be fixed in the next EUI release (approx ~2 weeks from now, as our most recent release/Kibana upgrade will not contain the fix). I'll try to remember to either remove your key workaround or ping y'all when that release is in Kibana!

@drewdaemon
Copy link

@constancecchen sounds good. Thank you for that quick turnaround!

@cee-chen
Copy link
Contributor

cee-chen commented Jan 6, 2022

@andrewctate Apologies, with the holidays I 100% forgot to ping you! This fix should be in latest Kibana at this point, so feel free to remove your key workaround whenever.

@drewdaemon
Copy link

Thanks, @constancecchen ! Will do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants