Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiTour] Built-in 'Next' button #5715

Closed
thompsongl opened this issue Mar 14, 2022 · 4 comments
Closed

[EuiTour] Built-in 'Next' button #5715

thompsongl opened this issue Mar 14, 2022 · 4 comments

Comments

@thompsongl
Copy link
Contributor

Would it be possible to have default Next behaviour added to the bottom of the tour steps? Right now I have to pass a custom footer action to each step except the final one, which is a bit clunky - I understand that, in the examples included in the documentation, the tour steps progress via actions such as copy pasting and clicking other buttons rather than clicking Next; however, I think that a Next button would, at the very least, be a common use case worth considering. Here is an example of what we had in our original tour for what was considered the 'default' footerAction:

<EuiFlexGroup responsive={false} gutterSize="s" alignItems="center">
  <EuiFlexItem grow={false}>
    <EuiButtonEmpty color="text" size="xs" onClick={actions.finishTour()}>
      Skip tour
    </EuiButtonEmpty>
  </EuiFlexItem>
  <EuiFlexItem grow={false}>
    <EuiButton size="s" color="success" onClick={actions.incrementStep()}>
      Next
    </EuiButton>
  </EuiFlexItem>
</EuiFlexGroup>

Which rendered to this:

image

Originally posted by @Heenawter in #5696 (comment)

@banderror
Copy link
Contributor

Security Solution is interested in this as well. We'd like to have some built-in previous/next buttons in the tour steps that would allow the user to navigate between the steps.

So far we had to add our custom buttons to the content of every step: elastic/kibana#128405

@github-actions
Copy link

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@Heenawter
Copy link
Contributor

I think this would still be a valuable addition 👍

@miukimiu
Copy link
Contributor

It was fixed by #6384. We just added support to pass an array of buttons to footerAction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants