Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EuiComboBox: Persistent placeholder in input #588

Closed
cjcenizal opened this issue Mar 28, 2018 · 2 comments
Closed

EuiComboBox: Persistent placeholder in input #588

cjcenizal opened this issue Mar 28, 2018 · 2 comments

Comments

@cjcenizal
Copy link
Contributor

cjcenizal commented Mar 28, 2018

Per #567 (comment), we could improve the UX by keeping a persistent placeholder to prompt the user to use the combo box.

Examples from Uniform and react-select feel pretty intuitive without the persistent placeholder so I wonder if the component is better without it, since no placeholder would simplify it visually.

@snide
Copy link
Contributor

snide commented Mar 28, 2018

I think you'll want one for the default empty in any case. Just to match against what every other one of our form components does.

I agree the persistent one isn't necessary, so feel free to close this if that's what you're referencing.

@cjcenizal
Copy link
Contributor Author

Definitely. I'll implement the default placeholder in the original PR. Closing this, since it's just for the persistent placeholder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants