Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EuiComboBox: Fix bugs inside of EuiModal #600

Closed
cjcenizal opened this issue Mar 30, 2018 · 2 comments
Closed

EuiComboBox: Fix bugs inside of EuiModal #600

cjcenizal opened this issue Mar 30, 2018 · 2 comments

Comments

@cjcenizal
Copy link
Contributor

Per #567 (comment):

EuiComboBox doesn't work inside of EuiModal. There's a problem with the tab order and the way the ESCAPE keypress is handled.
@jgowdyelastic jgowdyelastic mentioned this issue Jul 24, 2018
Merged
@thompsongl
Copy link
Contributor

@cjcenizal I don't have any details on what specific bugs you were seeing, but it's very likely they were fixed as part of #1550, which resolved a lot of problems related to portals and tab order

kapture 2019-02-21 at 11 32 21

@cjcenizal
Copy link
Contributor Author

Nice! Thanks for the head's up @thompsongl. Tested on the docs site and it looks like this was fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@snide @cjcenizal @thompsongl