Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiBasicTable] Add option to render metadata + bulk actions in header #6004

Closed
sebelga opened this issue Jun 27, 2022 · 4 comments
Closed
Assignees

Comments

@sebelga
Copy link
Contributor

sebelga commented Jun 27, 2022

As part of the work the improve UX for the in Kibana (the page rendering the list of dashboards, visualisations, maps) we want to render a "selection info" bar on top of the <EuiBasicTable /> with the following functionalities

  • Display how many items are being viewed (e.g. "Showing 1-10 of 45 Dashboards")
  • Once one or multiple items are selected
    • Render a context menu to process bulk actions on the items
    • Render a button to select all the visible items in the table
    • Render a button to clear the selection

Design

Screenshot 2022-06-27 at 15 58 00

Bulk actions

Screen Shot 2022-06-27 at 11 07 27 AM

@sebelga sebelga self-assigned this Jun 27, 2022
@chandlerprall
Copy link
Contributor

I don't know that this provides enough value to bake into EuiBasicTable. It's additive to the table, but doesn't appear specific enough to tables to be built into the component, feels more standalone. The selection logic also looks like it disagrees with our approach where selection should only apply to the rows currently rendered.

As a concept, we agree on adding a toolbar component to EUI, captured by #3500 but we could use your use case there!

@cchaos
Copy link
Contributor

cchaos commented Jun 27, 2022

I don't know that this provides enough value to bake into EuiBasicTable.

I disagree. Every table instance could benefit from displaying (at least) the row/count totals and the added ability to quickly deselect rows (if selection is enabled).

For sure this is part of the idea behind the toolbar component, though, and it's probably best to start there as a generic and then allow the table components to have them turned on/off.

@sebelga
Copy link
Contributor Author

sebelga commented Jun 28, 2022

I don't mind building this feature for our need and if you see the value bring it to EUI. I wouldn't want the UX work of the table list in Kibana to be delayed until we agree on a generic toolbar for multiple purposes.

Seeing the length #4010 it seems that we might be better starting in Kibana.

@sebelga
Copy link
Contributor Author

sebelga commented Sep 7, 2022

Closing in favour of elastic/kibana#140185 (we'll implement it initially for the Table list view)

@sebelga sebelga closed this as completed Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants