Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create id propType checker to ensure value begins with a letter #640

Closed
cjcenizal opened this issue Apr 9, 2018 · 1 comment
Closed

Create id propType checker to ensure value begins with a letter #640

cjcenizal opened this issue Apr 9, 2018 · 1 comment
Labels
bug

Comments

@cjcenizal
Copy link
Contributor

#637 surfaced an issue in which numeric IDs are not compliant with HTML 4. We can create a propType checker for the id prop which will warn the consumer when a numeric value is provided.
@cjcenizal cjcenizal added the bug label Apr 9, 2018
@cjcenizal cjcenizal mentioned this issue Apr 9, 2018
Merged
@snide snide mentioned this issue Apr 30, 2018
Closed
44 tasks
@chandlerprall
Copy link
Contributor

Closing this due to moving away from explicitly writing propTypes, and the fact that HTML5 does support numeric IDs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chandlerprall @snide @cjcenizal